rpc-compat: remove Author from BlockForRpc #8146
Open
+28
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowosie
force-pushed
the
pnowosie/rpc-compat-get-block-remove-author
branch
from
c54fbbf to
9ae4408
Compare
MarekM25
approved these changes
Jan 31, 2025
benaadams
approved these changes
Feb 11, 2025
Could just change the
To
And let the Json nullability remove it from output then? |
benaadams
requested changes
Feb 11, 2025
| @@ -30,7 +30,6 @@ protected BlockForRpc() | |||
| public BlockForRpc(Block block, bool includeFullTransactionData, ISpecProvider specProvider) | |||
| { | |||
| _isAuRaBlock = block.Header.AuRaSignature is not null; | |||
| Author = block.Author ?? block.Beneficiary; | |||
There was a problem hiding this comment.
Change to
Author = block.Author;
Then let [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Authorfield from BlockForRpcTypes of changes
Removes redundant field from RPC getBlockBy * response.
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?